zig: fix compilation on Darwin AArch64#181143
Closed
strager wants to merge 1 commit intoNixOS:masterfrom
Closed
Conversation
On macOS AArch64, Zig's zig0 build is failing with the following error:
Undefined symbols for architecture arm64:
"operator delete[](void*)", referenced from:
lld::elf::Configuration::~Configuration() in liblldELF.a(Driver.cpp.o)
...
"operator delete(void*)", referenced from:
_ZigLLVMGetNativeFeatures in libzigcpp.a(zig_llvm.cpp.o)
...
"operator new[](unsigned long)", referenced from:
bigint_unsigned_division(BigInt const*, BigInt const*, BigInt*, BigInt*) in libzigstage1.a(bigint.cpp.o)
...
"operator new(unsigned long)", referenced from:
_ZigLLVMTargetMachineEmitToFile in libzigcpp.a(zig_llvm.cpp.o)
...
"operator new(unsigned long, std::nothrow_t const&)", referenced from:
_ZigLLVMTargetMachineEmitToFile in libzigcpp.a(zig_llvm.cpp.o)
...
ld: symbol(s) not found for architecture arm64
clang-13: error: linker command failed with exit code 1 (use -v to see invocation)
This is because libc++ is selected during linking, but the libc++abi
isn't linked. Link libc++abi to fix the errors.
I think macOS x86_64 is still failing for a different reason.
13 tasks
Contributor
|
https://hydra.nixos.org/build/184023245
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS AArch64, Zig's zig0 build is failing with the following error:
This is because libc++ is selected during linking, but the libc++abi
isn't linked. Link libc++abi to fix the errors.
I think macOS x86_64 is still failing for a different reason.
Description of changes
HELP: Do I need to document somewhere that libc++abi was added to all libc++-using builds? This patch affects more than just the zig package.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes